Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trim doesn't affect PFL channels #207

Open
cs-endo opened this issue Feb 8, 2021 · 1 comment
Open

Trim doesn't affect PFL channels #207

cs-endo opened this issue Feb 8, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@cs-endo
Copy link

cs-endo commented Feb 8, 2021

If you turn on the "PFL Channel" pro option and then change the trim level, the volume stays the same. The effect only appears when PFL is not enabled. I don't know if this is intentional or not but if PFL is supposed to mirror what goes out on air I think it makes more sense to have it register trim changes.

@cs-endo cs-endo added the bug Something isn't working label Feb 8, 2021
@mstratford
Copy link
Member

So this is a technical limitation of the implementation, coupled with the (relative) simplicity aspect.

The PFL output is tapped before the gain node of wavesurfer, as such the fader volume doesn't affect the headphones.

To change this behaviour, the fader volume would have to be refactored to operate as a separate webaudio node, after the gain control.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants