Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Organisation course add #1430

Open
tfhuhtal opened this issue Jan 14, 2025 · 0 comments
Open

Organisation course add #1430

tfhuhtal opened this issue Jan 14, 2025 · 0 comments

Comments

@tfhuhtal
Copy link
Contributor

tfhuhtal commented Jan 14, 2025

#1422

This pull request includes several changes to enhance the functionality and user experience of the organisation survey feature. The updates include modifications to the translation files, improvements to the frontend components, and significant backend changes for handling courses associated with surveys.

Translation Updates:

  • Added the "removeCourse" translation to public/locales/en/translation.json, public/locales/fi/translation.json, and public/locales/sv/translation.json. [1] [2] [3]

Frontend Enhancements:

  • Updated EditOrganisationSurvey.jsx to include courses in the survey data and corrected the mapping of course IDs. [1] [2]
  • Enhanced CourseSearchInput.tsx by adding a confirmation dialog when removing courses, using Chip for selected courses, and ensuring proper state management for date range options. [1] [2] [3] [4] [5]
  • Removed unnecessary Chip component from OrganisationSurveyEditor.jsx.

Backend Enhancements:

  • Created a new migration to add the organisation_survey_courses table.
  • Updated organisationSurveyController.js to handle the creation and editing of organisation survey courses. [1] [2]
  • Added new methods in organisationSurveys.js for managing organisation survey courses and retrieving course students. [1] [2] [3] [4] [5]

This is related to issues #1357 , #1408 and to feature-draft documentation/feature_drafts/20241217_00_opiskelijoiden_tuonti_kursseilta_organisaatiokyselyyn.md

Originally posted by @tfhuhtal in #1422

@github-project-automation github-project-automation bot moved this to Wishlist in Norppa Backlog Jan 16, 2025
@mluukkai mluukkai moved this from Wishlist to Ready for review in Norppa Backlog Jan 16, 2025
@AstaLW AstaLW moved this from Ready for review to In review in Norppa Backlog Jan 21, 2025
@Veikkosuhonen Veikkosuhonen moved this from In review to Waiting for QA in Norppa Backlog Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Waiting for QA
Development

No branches or pull requests

1 participant