Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply fix for trajectory execution race condition to ScaledJointTrajectoryController #697

Closed
schornakj opened this issue May 26, 2023 · 2 comments

Comments

@schornakj
Copy link

The JointTrajectoryController in ros2_controllers had a race condition in which trajectory execution could erroneously succeed while the robot was still in motion, which caused undesirable behavior when performing multiple motion plans and trajectories in series.

Since this repo's ScaledJointTrajectoryController is based on JointTrajectoryController, it probably also has the same problem.

To resolve this, the changes from ros-controls/ros2_controllers#565 need to be applied to ScaledJointTrajectoryController.

@panagelak
Copy link

@schornakj @fmauch

I create a pr for this for humble branch #710

@fmauch
Copy link
Contributor

fmauch commented Sep 21, 2023

Should be resolved by #810, #811, #813

@fmauch fmauch closed this as completed Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants