Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prettier formats lists wrong - Update Prettier dependency #151

Open
stevenzeck opened this issue Oct 26, 2018 · 4 comments
Open

Prettier formats lists wrong - Update Prettier dependency #151

stevenzeck opened this issue Oct 26, 2018 · 4 comments

Comments

@stevenzeck
Copy link
Contributor

stevenzeck commented Oct 26, 2018

From @muuvmuuv on October 24, 2018 7:17

I am using the VS Code extension and every time I format a file it converts the - to * which is wrong regarding this issue prettier/prettier#4251. I don't know why it does this, I thought the beautifiers are using the same version as the CLI does, because when I use the prettier CLI with prettier file.md --write everything is fine.

Prettier: v1.14.3
Unibeautify: v0.6.1
VSCode: 1.28.2

## [1.0.3]

- Updated README
- Moved pre-push to .git

converts to

## [1.0.3]

* Updated README
* Moved pre-push to .git

Config is

{
  "Markdown": {
    "beautifiers": ["Prettier"],
    "wrap_line_length": 80,
    "wrap_prose": "always"
  }
}

Copied from original issue: Unibeautify/beautifier-prettier#127

@stevenzeck
Copy link
Contributor Author

From @muuvmuuv on October 24, 2018 7:19

ah, I forgot to mention that the Unibeautify CI does it the correct way, see: https://github.com/muuvmuuv/vscode-sundial/compare/unibeautify/master/push?expand=1#diff-4ac32a78649ca5bdd8e0ba38b7006a1e

@stevenzeck
Copy link
Contributor Author

Were any changes made by Prettier after 1.12.1? That might be why since VSCode is still on that version.

@stevenzeck
Copy link
Contributor Author

@stevenzeck
Copy link
Contributor Author

Just need to update prettier for the VSCode extension.

@Glavin001 Glavin001 changed the title Prettier formats lists wrong Prettier formats lists wrong - Update Prettier dependency Oct 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants