Skip to content
This repository has been archived by the owner on Aug 20, 2018. It is now read-only.

configs and saves' base paths are inconsistent #7

Open
USCSolarCarStrategy opened this issue Jan 8, 2017 · 7 comments
Open

configs and saves' base paths are inconsistent #7

USCSolarCarStrategy opened this issue Jan 8, 2017 · 7 comments
Assignees

Comments

@USCSolarCarStrategy
Copy link
Contributor

For example, yutong keeps changing the path "../config/voltage.cfg" and I keep having to changing it to "./config/voltage.cfg"

We can either

  1. figure out why our default runtime path is different, or
  2. create a way for the code to handle it properly and not crash more 'gracefully' rather than completely exiting program.
@YutongGu
Copy link
Contributor

Wait I'm changing it to "./whatever" each time. Is everyone else doing the same? What works for everyone?

@im-deepfriedwater
Copy link
Contributor

For me and @yshin4 we can both run telemetrysc.py with the current filepaths which can be seen beginning at telemetry/scsui/graphs.py Line 18

"../whatever" is currently what works for us.

I'll do some preliminary investigating to see what might be causing this.

@yshin4
Copy link

yshin4 commented Jan 18, 2017

On a side note, we don't have to change anything. It was set to "../whatever".

@im-deepfriedwater
Copy link
Contributor

Changing the file paths in telemetry/scsui/graphs.py to "./whatever" does not work and also "/whatever" does not work. "../whatever" is the only one that does not crash.

Also, system spec wise @yshin4 and I are both on Windows 10 64 bit just in case it's relevant.

@im-deepfriedwater
Copy link
Contributor

I think I'll try out a change in telemetry/scsui/graphs.py that might work out on Yutong's.

@im-deepfriedwater
Copy link
Contributor

Pushed a change to telemetry/scsui/graphs.py that should be more platform independent than was previously. @YutongGu should see if it fixes the error he was running into.

@hakuliu
Copy link
Contributor

hakuliu commented Jan 20, 2017

if we can verify with everyone it's working, we can go ahead and close this?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants