Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to using Conda lock files to specify requirements and update dependencies #949

Closed
wants to merge 7 commits into from

Conversation

matt-graham
Copy link
Collaborator

@matt-graham matt-graham commented Apr 20, 2023

Switches from using pip-compile and requirements.txt files to specify Python dependencies to be installed using pip to using conda-lock to generate lock files specifying (platform specific) Conda environments with both Python and non-Python dependencies.

Also currently set to update dependencies to Python 3.11 and Pandas 2.0.0 - we could potentially pin to the current Python (v3.8) / Pandas (v1.2.2) versions instead to split the change over how we're handling dependencies and the actual updating of dependencies.

@matt-graham
Copy link
Collaborator Author

matt-graham commented Apr 20, 2023

Currently CI not running correctly, I think probably because of a combination of conda not being installed on test runners and the tox version installed being too old (ideally 3.15 plus is needed I think). @tamuri would you be able to install conda and update tox on the test runners at some point?

EDIT: I think I was misreading the log previously - looks like the problem is only with conda not being installed, the installed tox version (3.24.5) seems to be fine.

@tamuri
Copy link
Collaborator

tamuri commented May 2, 2023

Conda has been installed on the runners.

@tamuri
Copy link
Collaborator

tamuri commented May 2, 2023

Also need to install tox-conda...doing that now

@matt-graham
Copy link
Collaborator Author

Interesting, when I ran locally I didn't need to install tox-conda separately because it is listed in the tox.requires section of the tox.ini file and so should be auto provisioned if a compatible version is not already installed. From the most recent run logs it looks like there is still a problem in finding the conda executable which might mean it is not getting added to PATH variable.

@tamuri
Copy link
Collaborator

tamuri commented Jul 21, 2023

Moving to conda requires sorting the tox config, GHA self-hosted runners, the container used by Azure Batch. It might not be straightforward. So, I have a suggestion: let's hold off installing the packages from conda i.e. simply update the files in requirements to update the dependencies. We can then start benefitting from all the work you've put in to this quickly. Then look at all these moving parts together and rationalise our approach. @giordano will be also be able to contribute to this.

@matt-graham
Copy link
Collaborator Author

I don't think we want to go forward with this one any more so closing.

@matt-graham matt-graham closed this Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants