Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consolidate Use of 'OPD' Appointment Type #1021

Merged
merged 8 commits into from
Jul 17, 2023
Merged

Consolidate Use of 'OPD' Appointment Type #1021

merged 8 commits into from
Jul 17, 2023

Conversation

tbhallett
Copy link
Collaborator

@tbhallett tbhallett commented Jul 12, 2023 •
edited
Loading

  • Removes the OPD footprint from the generic first appointments (as these HSI serve to schedule other peices of care and so is duplicative.)
  • Add footprint to a malaria HSI that was missing one
  • Edits to the measles to allow for use of Over5OPD or Under5OPD according to age
  • Consolidates HSI schedueled by CardioMetabolicDisorders to prevent many follow-up HSI being scheduled for the same person.

@tbhallett
Copy link
Collaborator Author

tbhallett commented Jul 13, 2023 •
edited
Loading

job-id testing this: long_run_all_diseases-2023-07-13T100358Z

These changes bring down the headline "Model:Data" ratio for OPD from 3.4 to 2.6

image

@tbhallett tbhallett marked this pull request as ready for review July 13, 2023 15:13
@tbhallett
Copy link
Collaborator Author

I'm going to put the changes to CDM in separate PR though, so we can track the specific impact of those separately for the major change to the FirstAppt stuff.

@tbhallett tbhallett mentioned this pull request Jul 16, 2023
Merged
@tbhallett
Revert "Let initial investigation for CDM conditions and events occur…
d51842d 
… within the same HSI (rather than one for each condition)"

This reverts commit 121a729.
@BinglingICL
Copy link
Collaborator

job-id testing this: long_run_all_diseases-2023-07-13T100358Z

These changes bring down the headline "Model:Data" ratio for OPD from 3.4 to 2.6

image

Thanks Tim. This looks great improvement!

BinglingICL
BinglingICL approved these changes Jul 17, 2023
View reviewed changes
Copy link
Collaborator

@BinglingICL BinglingICL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Tim, these changes all look great to me. Many thanks!

@tbhallett tbhallett merged commit e86be71 into master Jul 17, 2023
55 checks passed
@tbhallett tbhallett deleted the hallett/consolidate_opd branch July 17, 2023 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BinglingICL BinglingICL BinglingICL approved these changes

@tdm32 tdm32 Awaiting requested review from tdm32

@marghe-molaro marghe-molaro Awaiting requested review from marghe-molaro

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tbhallett @BinglingICL