Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ML FanData is limited to an odd number of detectors #1511

Open
robbietuk opened this issue Sep 12, 2024 · 0 comments
Open

ML FanData is limited to an odd number of detectors #1511

robbietuk opened this issue Sep 12, 2024 · 0 comments
Labels

Comments

@robbietuk
Copy link
Collaborator

This is an summary of the issue discussed in #1499 , specifically from #1499 (comment) onwards.

This is an issue for scanners with an even number of tangential positions because the fan data does not account for the min_tangential_poss() element when applying norm factors. The resulting efficiency/ normalization values in min_tangential_poss() positions will be 0 or +inf, which will lead to numerous problems.


The fix would be to extend the fan data to allow for an even number of entries, but this code issue is spread throughout ML Norm (#1499 (comment))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant