Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix OSX clang problems #1496

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

fix OSX clang problems #1496

wants to merge 2 commits into from
+40 −23

Conversation

KrisThielemans
Copy link
Collaborator

fixes #1490

@KrisThielemans KrisThielemans self-assigned this Aug 25, 2024
@KrisThielemans
change tests with intentional errors to catch std::runtime_error
e27c966 
Some tests check if errors are thrown. We caught any exception with
`catch (...)`. but that fails on OSX  Clang 18. Now we catch
`std::runtime_error`, which is more accurate anyway.

Fixes UCL#1490
@KrisThielemans KrisThielemans marked this pull request as draft August 25, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@KrisThielemans KrisThielemans

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clang 18 on MacOS tests fail due to uncaught (but intentional) exceptions
1 participant
@KrisThielemans