Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check target/ra/dec values in raw headers for entire scan #32

Open
mattlebofsky opened this issue Nov 8, 2021 · 2 comments
Open

Check target/ra/dec values in raw headers for entire scan #32

mattlebofsky opened this issue Nov 8, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@mattlebofsky
Copy link
Member

Something that comes up from time to time is that rawspec picks the very first target name and ra and dec from the first data block and assumes that's gospel, when in fact there may be a reporting delay such that the first data block contains old values (i.e. from the previous target) and the real values don't appear in the raw data header blocks until N seconds into the scan.

I don't know what the algorithm would be for trusting which values are correct, but it would be nice if rawspec would simply fail out if the target/ra/dec changes in the raw headers during the course of a scan. Of course there may be tiny tiny changes in ra/dec normally so don't worry about those. But if the target name changes at all, or the ra/dec changes more than a beam width, rawspec should fail without doing anything.

@radonnachie
Copy link
Contributor

Not to sound too idealistic, but isn't the preferable solution to mitigate the reporting delay?

Wouldn't rawspec failing on a change mean that you wouldn't be able to process the RAW files that had headers populated with significant reporting delays (such as in the case that gave rise to this issue)... in which case rawspec failing wouldn't be helpful, but inhibiting?

@radonnachie
Copy link
Contributor

radonnachie commented Nov 10, 2021

Perhaps it'd be preferable to have an argument that enables the reading of meta data from an offset RAW header, or even just the last header of the file (just a calculated fpeek()). That'd be quite possible I rate, and I think it should be an appropriate solution for delayed reporting?

@texadactyl texadactyl added the enhancement New feature or request label Nov 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants