Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check DIRECTIO flag when reading data #10

Open
wfarah opened this issue Nov 23, 2020 · 3 comments
Open

Check DIRECTIO flag when reading data #10

wfarah opened this issue Nov 23, 2020 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@wfarah
Copy link

wfarah commented Nov 23, 2020

An assumption (which might be true for most of the cases) is that BLOCSIZE is always a multiple of 512, and so the rawspec reader does not check for the DIRECTIO flag when reading data payload. With ATA data, the packet format is flexible and dynamic enough such that this alignment might not always be true.

TODO: add logic to seek to the next multiple of 512 when reading data in if DIRECTIO header flag exists and is enabled.

@wfarah wfarah self-assigned this Nov 23, 2020
@texadactyl texadactyl added the enhancement New feature or request label Nov 17, 2021
@dmkunsman
Copy link

@wfarah are you still working on this?...if not. I could try to implement it.

@texadactyl
Copy link
Contributor

texadactyl commented Jan 14, 2022

@wfarah @RocketRoss
Was this fixed in one of the ATA PRs?
rawspec_utils.c has some logic to this effect.

@radonnachie
Copy link
Contributor

I haven't double checked the mechanisms around this. I feel like we would've noticed if something was off

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants