[TT-13257] Fix websocket upgrade with multiple values in Connection header #6619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
titpetric
changed the title
|
Hi, thank you for the contribution. The approach looks good for the most part, two requests raised from review:
Thank you :) |
|
@titpetric You can re-review. 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To check for Websocket connection upgrade, replaces the "!=" check with the "not contains" check.
Related Issue
Closes #6449.
How This Has Been Tested
A test case has been added.
Types of changes
Checklist
I explained why this PR updates go.mod in detail with reasoning why it's requiredI would like a code coverage CI quality gate exception and have explained why