Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI setup #111

Merged
merged 2 commits into from
Jan 23, 2025
Merged

Update CI setup #111

merged 2 commits into from
Jan 23, 2025

Conversation

penelopeysm
Copy link
Member

@penelopeysm penelopeysm commented Jan 23, 2025

This is broadly in line with what Turing / DynamicPPL has.

Main changes are:

  • Bumping versions of actions
  • Also changing 1.6 -> 'min' so that we don't have to update that in the future
  • Also changing the 'nightly' test (brittle) to a new prerelease workflow
  • Using aarch64 on macOS rather than x64

While doing this I found that the minimum Julia bound of 1.6 was not correct: AdvancedPS depends on Libtask 0.8, which sets a minimum bound of Julia 1.7, so I updated that too.

Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.59%. Comparing base (1e5dfdd) to head (7d2ef12).
Report is 13 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #111      +/-   ##
==========================================
+ Coverage   96.09%   96.59%   +0.49%     
==========================================
  Files           8        8              
  Lines         410      411       +1     
==========================================
+ Hits          394      397       +3     
+ Misses         16       14       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coveralls
Copy link

coveralls commented Jan 23, 2025

Pull Request Test Coverage Report for Build 12927897864

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.5%) to 96.594%

Totals Coverage Status
Change from base Build 12927587973: 0.5%
Covered Lines: 397
Relevant Lines: 411

💛 - Coveralls

@penelopeysm penelopeysm requested a review from mhauru January 23, 2025 11:17
Copy link
Member

@mhauru mhauru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like solid improvements all around

@penelopeysm penelopeysm merged commit 5a36d31 into master Jan 23, 2025
12 checks passed
@penelopeysm penelopeysm deleted the py/ci branch January 23, 2025 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants