Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide option to pass on data with periods not starting at 1 #81

Open
lottekremer opened this issue Dec 19, 2024 · 0 comments
Open

Provide option to pass on data with periods not starting at 1 #81

lottekremer opened this issue Dec 19, 2024 · 0 comments

Comments

@lottekremer
Copy link

Description

Currently, when trying to use find_representative_periods on a dataframe with periods not starting at one (for example trying to run it for the second month, period 31:60), the function behaves differently based on the combination of distance metric and clustering method used. It will either work as expected or it breaks without a clear error message.

I would suggest to either not allow it and throw and error message in the beginning, making sure that the list of periods starts at 1, or adapt the function to work with period list not starting at 1.

Validation and testing

The error was given when using SqEuclidean() as distance metric and :convex_hull as clustering method.
No error was given when using k_medoids as clustering method with CityBlock(), CosineDist(), SqEuclidean()

I did not debug it any further as I just renamed my periods.

Motivation

It can be relevant for users who want to look at a specific month of the data instead of the whole year and want to find representative periods for that month.

Target audience

No response

Can you help?

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant