SQLMesh decorator processing fails with AttributeError for imported decorators

[rbreejen]

Description

When using imported decorators in SQLMesh models, the processing fails with AttributeError: 'Attribute' object has no attribute 'id'. Possible cause: SQLMesh's AST processing assumes all decorators are Name nodes, but they can also be Attribute nodes depending on the import style.

Reproduction

Environment

• Python 3.12
• SQLMesh latest
• tenacity (or other decorators?)

Steps

1. Create a new file test_model.py:

from tenacity import retry, stop_after_attempt
from sqlmesh import model
import pandas as pd
from datetime import datetime
from sqlmesh import ExecutionContext
import typing as t


@retry(stop=stop_after_attempt(3))
def fetch_data():
    return "test data"

@model(
    name='test.raw_data',
    description='Test model with retry decorator',
    columns={
        "data": "text",
        "_sqlmesh__extracted_at": "timestamp"
    },
)
def execute(
    context: ExecutionContext,
    start: datetime,
    end: datetime,
    execution_time: datetime,
    **kwargs: t.Any,
) -> pd.DataFrame:
    data = fetch_data()
    return pd.DataFrame([{
        "data": data,
        "_sqlmesh__extracted_at": execution_time
    }])

2. Run SQLMesh:

sqlmesh plan

Error

AttributeError: 'Attribute' object has no attribute 'id'

Expected Behavior

The model should process successfully, handling the @retry decorator.

[rbreejen]

I created a test around it in test_metaprogramming.py for debugging:

def test_decorator_name_with_attribute():
    @retry(stop=stop_after_attempt(3))
    def fetch_data():
        """Test function with retry decorator"""
        return "test data"

    # The test should fail when trying to process this function's decorators
    with pytest.raises(AttributeError, match="'Attribute' object has no attribute 'id'"):
        decorators(fetch_data)


def test_decorator_in_sqlmesh_model():
    # Mock the fetch_data function with retry decorator
    @retry(stop=stop_after_attempt(3))
    def fetch_data(url: str) -> str:
        return "<xml>test data</xml>"

    # Simplified version of your model
    @model(
        name='test.raw_data',
        description='Test model with retry decorator',
        kind=dict(name=ModelKindName.FULL),
        columns={
            "data": "text",
            "_sqlmesh__extracted_at": "timestamp"
        },
    )
    def execute(
        context: ExecutionContext,
        start: datetime,
        end: datetime,
        execution_time: datetime,
        **kwargs: t.Any,
    ) -> pd.DataFrame:
        # Use the decorated function
        data = fetch_data("https://api.example.com")
        return pd.DataFrame([{
            "data": data,
            "_sqlmesh__extracted_at": execution_time
        }])

    # Test that building the environment fails due to decorator
    env: t.Dict[str, t.Any] = {}
    with pytest.raises(AttributeError, match="'Attribute' object has no attribute 'id'"):
        build_env(execute, env=env, name="TEST_MODEL", path=Path("test_metaprogramming.py"))