Feat: Support top level properties in model_defaults #3696
+140
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erindru
reviewed
Jan 23, 2025
| @@ -40,6 +40,7 @@ Configuration options for SQLMesh model properties. Supported by all model kinds | |||
| | `gateway` | Specifies the gateway to use for the execution of this model. When not specified, the default gateway is used. | str | N | | |||
| | `optimize_query` | Whether the model's query should be optimized. This attribute is `true` by default. Setting it to `false` causes SQLMesh to disable query canonicalization & simplification. This should be turned off only if the optimized query leads to errors such as surpassing text limit. | bool | N | | |||
| | `validate_query` | `validate_query` | Whether the model's query will be strictly validated at compile time. This attribute is `false` by default. Setting it to `true` causes SQLMesh to raise an error instead of emitting warnings. This will display invalid columns in your SQL statements along with models containing `SELECT *` that cannot be automatically expanded to list out all columns. | bool | N | | |||
|
|
|||
| ### Model defaults | |||
There was a problem hiding this comment.
Might want to add a note somewhere in the docs about how to un-set a default at the model level.
It looks like this is supported by defining the property as None at the model level
There was a problem hiding this comment.
Yes good point, added an explanation and an example to make it clear how to unset a property
themisvaltinos
force-pushed
the
themis/model_defaults
branch
from
dce784a to
1154b8e
Compare
| session_properties[k] = exp.Literal.string(k).eq(v) | ||
| if k not in properties: | ||
| properties[k] = exp.Literal.string(k).eq(v) | ||
| elif properties[k].expression.sql().lower() in {"none", "null"}: |
There was a problem hiding this comment.
Is matching null here safe? Can that be an actual property value?
There was a problem hiding this comment.
This is to match for python models properties where None will be null here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update extends the support for top-level properties to be enabled project wide, fixes: #3599
Don't know if it makes sense to include more, as the others seem quite model-specific, but I’m happy to add them if anyone feels they’re necessary.