Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPICE edits and triggering sim #24

Open
psychogenic opened this issue Feb 3, 2023 · 3 comments
Open

SPICE edits and triggering sim #24

psychogenic opened this issue Feb 3, 2023 · 3 comments
Labels

Comments

@psychogenic
Copy link

When editing the SPICE, changes are noticed by the system but it will only run the simulation once the textarea loses focus. It makes sense that we wouldn't attempt to run while edits are still being made, but it would be nice to have at least one of

  • some indication that edits have been noted but are still pending (i.e. having a style for "dirty" textarea or something like that)
  • some button like "run" (it wouldn't actually have to do anything as clicking would change focus); or
  • some note about how to trigger a sim after edit (e.g. "press TAB" to run)
@mattvenn
Copy link
Collaborator

mattvenn commented Feb 5, 2023

editing spice is advance mode and we might even remove it (though it's very useful for debugging). not expected to be used by majority of users.

also after editing spice the sim sliders don't work, and updating the drawing doesn't work. So it would have to be quite clever to allow those behaviours while still allowing spice edit

@urish
Copy link
Member

urish commented Feb 5, 2023

Yes. Might worth adding "(expert)" next to "Show SPICE" or "Edit SPICE" texts

@urish urish added the post-mvp label Feb 8, 2023
@mattvenn
Copy link
Collaborator

definitely want the 'spice working' signal to show that things are being computed in the background

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants