Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicit Python >= 3.7 support #25

Open
leycec opened this issue Aug 20, 2020 · 1 comment
Open

Explicit Python >= 3.7 support #25

leycec opened this issue Aug 20, 2020 · 1 comment

Comments

@leycec
Copy link

leycec commented Aug 20, 2020

The PyPI project page for pymerkletools currently only lists explicit supports for Python <= 3.6. More importantly, TravisCI tests currently only test pymerkletools under Python 2.7 and 3.5. However, I can personally confirm that pymerkletools both installs and behaves as expected under at least Python 3.7. The same probably follows for Python 3.8 as well.

Thankfully, the fix appears trivial:

  • Explicitly list Python 3.6, 3.7, and 3.8 in .travis.yml to guarantee compatibility: e.g.,
python:
  - "2.7"
  - "3.5"
  - "3.6"
  - "3.7"
  - "3.8"
  • Explicitly list Python 3.5, 3.6, 3.7, and 3.8 in setup.py for PyPI readability: e.g.,
    classifiers=[
        "Intended Audience :: Developers",
        "Intended Audience :: Education",
        "Intended Audience :: Science/Research",
        "License :: OSI Approved :: MIT License",
        "Programming Language :: Python :: 2.7",
        "Programming Language :: Python :: 3.5",
        "Programming Language :: Python :: 3.6",
        "Programming Language :: Python :: 3.7",
        "Programming Language :: Python :: 3.8",
        "Topic :: Software Development :: Libraries",
        "Topic :: Software Development :: Libraries :: Python Modules"
    ],

Thanks for all Merkle, @Tierion! You rock the Bitcoin Casbah. 🥇

@KuzonFyre
Copy link

I am leaving this as a warning to others. I installed an older version of python to run this but was having trouble specifying which python to install it to. Use this command

python3.6 -m pip install merkletools

to specify which python pip is installing merkle tools to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants