Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dock_from_desc() support for GitLab #43

Open
michkam89 opened this issue Aug 11, 2022 · 1 comment
Open

dock_from_desc() support for GitLab #43

michkam89 opened this issue Aug 11, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@michkam89
Copy link

michkam89 commented Aug 11, 2022

Hi,

I see that dock_from_desc() only supports CRAN and GitHub packages. I saw #16, so is it maybe planned to add GitLab as well in the near future? I would also be interested in supporting on-prem hosts here, not only gitlab.com.

If not, are you open to providing some pull requests in this matter?

Thanks!

@statnmap
Copy link
Member

Now that we use {attachment} in {golem}, we would be able to use functionalities that detects other sources, and combine with what exists in {dockerfiler}.
Some ongoing issues are listed in {attachment} in this way: https://github.com/ThinkR-open/attachment/issues
GitLab is already accounted for in attachment::find_remotes() to fill your DESCRIPTION file.
Then, sub-functions of create_dependency_file() could be used to fill this Dockerfile as described in this issue: ThinkR-open/attachment#56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants