Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As user, I don't want to have to think if I need inside_rmd or not when using att_from_rmd() #106

Open
6 tasks
statnmap opened this issue Nov 30, 2023 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@statnmap
Copy link
Member

As user, I don't want to have to think if I need inside_rmd or not when using att_from_rmd(), so that the same function can be presented in help as in the classical use.

Criteria of success

  • There is no more inside_rmd parameter to be chosen by the user
  • att_from_rmd() works the same, inside or outside rmd
  • Readme and doc of {attachment} is simplified to deal with this change
  • Make {callr} a Suggest of the package

Tech

  • use outside_knit <- is.null(knitr::opts_knit$get("out.format")) to detect if we are in or outside a knitting environment, thus running directly the code, or run using callr:r() call.
  • {callr} is only needed if using the function when running knit, which is not really frequent with {attachment}, except for documentation and courses.
@statnmap statnmap added enhancement New feature or request good first issue Good for newcomers labels Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant