Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark mode #7347

Open
3 of 6 tasks
pierrephz opened this issue Oct 17, 2024 · 3 comments
Open
3 of 6 tasks

Dark mode #7347

pierrephz opened this issue Oct 17, 2024 · 3 comments
Assignees
Labels
c/console This is related to the Console
Milestone

Comments

@pierrephz
Copy link
Contributor

pierrephz commented Oct 17, 2024

Summary

Introduce the dark mode feature.

Current Situation

Currently we only have a light mode.

Why do we need this? Who uses it, and when?

Like in a lot of products and web apps, we should be able to switch themes to increase accessibility.

Proposed Implementation

Add theme switcher in the settings:

1 - Add a Theme setting under User settings
2 - Choose between Light, Dark and System mode
3 - Save or Discard

Screenshot 2024-10-17 at 11 42 10

Add dark mode tokens

Contributing

  • I can help by doing more research.
  • I can help by implementing the feature after the proposal above is approved.
  • I can help by testing the feature before it's released.

Validation

Code of Conduct

@pierrephz pierrephz added the needs/triage We still need to triage this label Oct 17, 2024
@pierrephz pierrephz self-assigned this Oct 17, 2024
@KrishnaIyer KrishnaIyer added c/console This is related to the Console and removed needs/triage We still need to triage this labels Oct 17, 2024
@KrishnaIyer KrishnaIyer added this to the v3.33.0 milestone Oct 17, 2024
@KrishnaIyer KrishnaIyer removed this from the v3.33.0 milestone Nov 11, 2024
@KrishnaIyer KrishnaIyer added the needs/discussion We need to discuss this label Nov 11, 2024
@KrishnaIyer
Copy link
Member

This looks great and ok for me. As discussed in the tech sync, this will require some update to the tokens in the process.

@KrishnaIyer KrishnaIyer removed the needs/discussion We need to discuss this label Nov 12, 2024
@KrishnaIyer KrishnaIyer added this to the Pipeline milestone Nov 12, 2024
@pierrephz
Copy link
Contributor Author

here are the assets to be able to build the settings page:

console-theme-light console-theme-dark console-theme-system

Download .zip
console-theme-settings-assets.zip

@pierrephz
Copy link
Contributor Author

pierrephz commented Jan 15, 2025

List of missing tokens:

  • TTS logo (Darya)
  • Regular modals (Pierre)
  • Search modal (Pierre - Darya)
  • Toggle element (not in the sidebar) (Pierre)
  • Disable link on a panel (Darya)
  • Dropdown menu (Pierre)
  • Tooltip (Pierre)
  • Icon background in the sidebar (Darya)
  • Hover state for the pagination number (Darya)
  • Selector in the pagination, and some inputs (Darya)
  • LoRa | Cloud logo (Pierre - Darya)
  • Error button (Pierre)
  • Primary button (Pierre) Missing chevron
  • Secondary button (Pierre)
  • Tertiary button (Pierre)
  • Disable button (Pierre)
  • Notification banner background (Pierre - Darya)
  • Decoded payload (Darya)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c/console This is related to the Console
Projects
None yet
Development

No branches or pull requests

3 participants