Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark fields which are only returned by field mask in API #443

Open
benolayinka opened this issue Jul 8, 2021 · 2 comments
Open

Mark fields which are only returned by field mask in API #443

benolayinka opened this issue Jul 8, 2021 · 2 comments

Comments

@benolayinka
Copy link
Contributor

Summary

The ids , created_at, updated_at and deleted_at are always returned by the IS. Everything else needs to be selected.

Why do we need this ?

So people aren't confused when fields aren't returned by API

Can you do this yourself and submit a Pull Request?

Yes

@benolayinka benolayinka added this to the 2021 Q3 milestone Jul 8, 2021
@benolayinka benolayinka self-assigned this Jul 8, 2021
@github-actions github-actions bot added the needs/triage We still need to triage this label Jul 8, 2021
@nejraselimovic nejraselimovic added documentation and removed needs/triage We still need to triage this labels Jul 13, 2021
@NicolasMrad NicolasMrad modified the milestones: 2021 Q3, 2021 Q4 Oct 1, 2021
@NicolasMrad NicolasMrad modified the milestones: 2021 Q4, 2022 Q1 Jan 4, 2022
@NicolasMrad NicolasMrad modified the milestones: 2022 Q1, 2022 Q2 Mar 29, 2022
@NicolasMrad
Copy link
Contributor

Is this still relevant or to be done soon since it has been moved for 3 quarters so far

@benolayinka
Copy link
Contributor Author

This is partially addressed by #475

Actually adding a field mask indicator will require manually updating request metadata which we aren't gonna do right now. Will mark gold plating and remove milestone

#475 (comment)

@benolayinka benolayinka removed this from the 2022 Q2 milestone Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants