Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initialize_floorplan fails without -site option #6063

Open
titan73 opened this issue Oct 30, 2024 · 3 comments
Open

initialize_floorplan fails without -site option #6063

titan73 opened this issue Oct 30, 2024 · 3 comments
Assignees
Labels
ifp Initialize Floorplan

Comments

@titan73
Copy link
Contributor

titan73 commented Oct 30, 2024

Describe the bug

The - site is supposed to be optional. A warning is printed but an error occurs later.

% initialize_floorplan -utilization 10
[WARNING IFP-0011] use -site to add placement rows.
TypeError in method 'init_floorplan_util', argument 7 of type 'odb::dbSite *'

% initialize_floorplan -die_area {0 0 10 10} -core_area {0 0 10 10}
[WARNING IFP-0011] use -site to add placement rows.
TypeError in method 'init_floorplan_core', argument 9 of type 'odb::dbSite *'

Is -site option really to be optional? Seems the contrary. In that case the warning should be turn into an error and doc updated.

Expected Behavior

No error.

Environment

Lastest git.

To Reproduce

Type:
initialize_floorplan -utilization 10
or
initialize_floorplan -die_area {0 0 10 10} -core_area {0 0 10 10}

Relevant log output

No response

Screenshots

No response

Additional Context

No response

@maliberty
Copy link
Member

It looks like it should be an error. Do you want to make a PR?

@maliberty maliberty added the ifp Initialize Floorplan label Oct 30, 2024
@titan73
Copy link
Contributor Author

titan73 commented Oct 30, 2024

Yes. I'll do it. Assign this issue to me.

@titan73
Copy link
Contributor Author

titan73 commented Oct 30, 2024

Sent PR #6069

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ifp Initialize Floorplan
Projects
None yet
Development

No branches or pull requests

2 participants