Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

documentation bug: link-hover-background and link-hover-color changed to link-background-hover and link-color-hover #3796

Closed
jessebot opened this issue Dec 2, 2023 · 3 comments

Comments

@jessebot
Copy link

jessebot commented Dec 2, 2023

The docs need to be updated here for the changed CSS values: https://textual.textualize.io/styles/links/

According to the changelog:

  • link-hover-background renamed to link-background-hover
  • link-hover-color renamed to link-color-hover

If you can point me at the location to update, I can do the update. I wasn't sure if these docs are auto-generated from the code or not though. And this search was little confusing because it only shows the change log: https://github.com/search?q=repo%3ATextualize%2Ftextual%20link-hover-background&type=code

I tried clearing my firefox cache, but didn't see the live textual.textualize.io page update.

Here's the error other users might find in their code base, to help with searching issues later:

╭─ Error at /home/friend/repos/smol-k8s-lab/smol_k8s_lab/tui/css/apps_config.tcss:36:5 ──────────────────────────────────────────────────────────────────────────────╮
│    34 │   border-title-color: $sky_blue;                                                                                                                           │
│    35 │   border-subtitle-color: $sky_blue;                                                                                                                        │
│ ❱  36 │   link-hover-background: $navy;                                                                                                                            │
│    37 │   link-hover-color: $orange;                                                                                                                               │
│    38 │   background: $navy 60%;                                                                                                                                   │
╰────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────╯
   Invalid CSS property 'link-hover-background'. Did you mean "link-background"?


╭─ Error at /home/friend/repos/smol-k8s-lab/smol_k8s_lab/tui/css/apps_config.tcss:37:5 ──────────────────────────────────────────────────────────────────────────────╮
│    35 │   border-subtitle-color: $sky_blue;                                                                                                                        │
│    36 │   link-hover-background: $navy;                                                                                                                            │
│ ❱  37 │   link-hover-color: $orange;                                                                                                                               │
│    38 │   background: $navy 60%;                                                                                                                                   │39 │   align: center top;                                                                                                                                       │
╰────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────╯
   Invalid CSS property 'link-hover-color'. Did you mean "link-color"?


 CSS parsing failed: 2 errors found in stylesheet

This was a dyslexia nightmare for a solid 30 minutes just staring at it being like, "how is the changelog changing.... nothing? 🤔" till I realized the words had been changed around 😅

@Textualize Textualize deleted a comment from github-actions bot Dec 2, 2023
@willmcgugan
Copy link
Collaborator

I had forgotten to deploy the docs after yesterday's update. They should be good now. Thanks for the offer of help!

@jessebot jessebot closed this as completed Dec 2, 2023
@jessebot
Copy link
Author

jessebot commented Dec 2, 2023

no problem and thanks for the quick fix!

Copy link

github-actions bot commented Dec 2, 2023

Don't forget to star the repository!

Follow @textualizeio for Textual updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants