Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] echarts themes get treeshaken on production builds #1775

Open
emoralesb05 opened this issue Jun 25, 2020 · 0 comments
Open

[Bug] echarts themes get treeshaken on production builds #1775

emoralesb05 opened this issue Jun 25, 2020 · 0 comments

Comments

@emoralesb05
Copy link
Contributor

emoralesb05 commented Jun 25, 2020 •
edited
Loading

Bug Report

When running ng serve --prod the themes get treeshaken

particularly this line of code

covalent/src/platform/echarts/base/base.module.ts

Line 20 in e2fc638

registerDefaultThemes();

What is the expected behavior?

Themes should still be bundled when building the application.

Other information

We need to figure out a different way to register the themes if the current way is considered tree shakable.

Either have the users always add that line, add docs about it and we remove the call, or we make it work in all scenarios.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@emoralesb05