IOS-10974 Allow ref param #423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amegias
commented
Jan 31, 2025
| @@ -59,10 +59,16 @@ const BRANDS = [ | |||
| const BRANCH = 'production'; | |||
|
|
|||
| const run = async () => { | |||
| let branch = BRANCH; | |||
| if (process.argv.length > 2) { | |||
There was a problem hiding this comment.
process.argv returns something like:
[
'/opt/homebrew/Cellar/node/23.5.0/bin/node',
'/xxxxxxx/mistica-ios/scripts/mistica-skin-generator/index.js',
'firstParam',
'secondParam',
'...'
]
cbarcom
approved these changes
Feb 2, 2025
pbartolome
approved these changes
Feb 3, 2025
|
🎉 This PR is included in version 33.8.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Jira ticket
https://jira.tid.es/browse/IOS-10974
🥅 What's the goal?
When
mistica-designjob trigger ourgenerate-mistica-tokens.yml, it fails:https://github.com/Telefonica/mistica-design/actions/runs/13055903096/job/36426747377#step:3:17
refparam is unexpected.🚧 How do we do it?
Allow this (optional) param.
🧪 How can I verify this?