-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IOS-10800 Make ViewStates component in SwiftUI #415
IOS-10800 Make ViewStates component in SwiftUI #415
Conversation
Hi @alejandroruizponce , |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There would be a missing test for this component, wouldn't there?
Thanks @AnaMontes11, but really my question is more about what type of button is correct for this View State component. If the one we use in UIKit or the SwiftUI one, or if both are valid. |
There were no tests for the component in UIKit either, if I can I will check and add some. |
Hi @alejandroruizponce, this is not a MΓstica component; I understand it comes from an old View State. On our side, it doesnβt matter if you use a small or large button, although for consistency, itβs better to use the same one in both. If this decision is relevant for Novum or could affect something in production, weβd need to discuss it with the product team. Let me know if Iβve clarified your question. |
Hello again, @alejandroruizponce As I mentioned, it seems like an older empty state. If it helps, I would use the same (large) button in the SwiftUI version for consistency and discuss with the team updating both to something closer to a more modern empty state. |
Talked with @AnaMontes11 and @aweell, same large button will be used on both platforms even though they are different right now. The unification of the button can be looked at in a different ticket as well as the update of the texts: |
ea6e0dc
to
7eca443
Compare
π This PR is included in version 33.7.0 π The release is available on GitHub release Your semantic-release bot π¦π |
ποΈ Jira ticket
https://jira.tid.es/browse/IOS-10800
π₯ What's the goal?
As a performance objective to make SwiftUI components, ViewStates component will be migrated from UIKit to SwiftUI.
π§ How do we do it?
A new component similar to the component in UIKit has been created and added inside the Catalog.
π§ͺ How can I verify this?
FOR DESIGN MEMBER (@AnaMontes11) : There is a difference between the buttons we have for SwiftUI and the UIKit buttons, I'm not clear which one should be the correct one since I can't find references to the Design of this component. I hope that in the revision of this PR a member of Design can clarify it.
If the SwiftUI design is correct, it could be used as a base and apply in UIKit a wrapper that encapsulates the SwiftUI design to use the same design in all platforms.
π AppCenter build