-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] Temporal fix meanwhile odoo uses -intra option in ffmpeg. This … #599
Conversation
Put the reference to Odoo code using that option. |
5a3e264
to
8463e22
Compare
This option is not compatible with ffmpeg lasts versions
8463e22
to
62bf205
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
chore: Add some extra rationale to the commit message:
Debian bookworm and upper versions use version 5 of ffmpeg (used in video test tours artifacts generation) which doesn't support the intra
flag used by Odoo (link).
This options has been deprecated for long time and we've proposed a fix (link to pr) for a modern alternative. While these changes aren't incorporated we'll force the version to support the current options.
It seems Odoo is also working on / proposed a fix for this: odoo/odoo#153270 |
Thanks @ap-wtioit ! |
Once that Odoo PR is merged maybe we should add that test to the doodba CI |
Meanwhile, I'm working in this PR as a temportal patch. Now I'am facing some compatibility issues between 4.x ffmepg version and bookworm, so we can't merge this PR yet. |
Another fix, would be to add a script E.g. (not tested): #!/usr/bin/env bash
if [[ $1 == "-intra" ]] ; then
# discard first argument -intra
shift
fi
exec /usr/bin/ffmpeg "$@" if you put this as ffmpeg into /home/odoo/.local/bin as ffmpeg it should remove the |
Let's wait for the following days to have the Odoo PR merged, and if no response, then let's go to alternative solutions. |
The fix is already merged in |
…option is not compatible with ffmpeg lasts versions.
https://github.com/OCA/OCB/blob/52bec035f3afbe4e1cc9e51e062ed35eb830e04f/odoo/tests/common.py#L1360
@Tecnativa TT48083