feature: 카카오로그인+스플래시 수정 #201
Open
+165
−61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junseo511
approved these changes
Oct 7, 2024
| package com.teamoffroad.feature.auth.domain.model | ||
|
|
||
| enum class SocialSignInPlatform { | ||
| EMPTY, |
| @@ -55,23 +58,12 @@ internal fun AuthScreen( | |||
| viewModel.performGoogleSignIn(task) | |||
| } | |||
| } | |||
| var showWebView by remember { mutableStateOf(false) } | |||
There was a problem hiding this comment.
c: showWebView는 동작을 의미하는 것 같아요 Boolean 값에 적절한 네이밍을 찾아보시죠!!
There was a problem hiding this comment.
isShowWebView 이런식으로 가야될 거 같아요.
| redirectUri = BuildConfig.KAKO_REDIRECT_URI, | ||
| onCodeReceived = { code -> | ||
| viewModel.performKakaoSignIn(code) | ||
| Log.d("asdasd", code) |
| override fun onPageStarted( | ||
| view: WebView?, | ||
| url: String?, | ||
| favicon: android.graphics.Bitmap? |
There was a problem hiding this comment.
축약자가 view 말하는 걸까요?
Comment on lines
6
to
7
| val autoSignIn: Boolean = false, | ||
| val authSignIn: Boolean = false, |
There was a problem hiding this comment.
c: 혹시 이 두 변수의 차이점을 알 수 있나요? 이친구도 좀 이름을 구체화해주시면 좋을 것 같아요!
There was a problem hiding this comment.
요거는 저도 쓰면서 헷갈렸는데 수정하겠습니다ㅋㅋㅋㅋ
| @@ -10,6 +10,7 @@ android { | |||
| } | |||
|
|
|||
| dependencies { | |||
| implementation(project(":feature:auth")) | |||
Comment on lines
35
to
42
| if (showSplash.value) { | ||
| SplashScreen() | ||
| } else { | ||
| MainScreen( | ||
| navigator = navigator, | ||
| modifier = Modifier | ||
| ) | ||
| } |
There was a problem hiding this comment.
c: 2원칙을 확인하시면 왜 제가 when을 선호하는지 아실 수 있어용 :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌𝘐𝘴𝘴𝘶𝘦𝘴
📎𝘞𝘰𝘳𝘬 𝘋𝘦𝘴𝘤𝘳𝘪𝘱𝘵𝘪𝘰𝘯
📷𝘚𝘤𝘳𝘦𝘦𝘯𝘴𝘩𝘰𝘵
Screen_recording_20241004_200026.mp4
Screen_recording_20241004_195649.mp4
💬𝘛𝘰 𝘙𝘦𝘷𝘪𝘦𝘸𝘦𝘳𝘴
수정하다보니 앱을 재시작시켜야 할 상황이 많은거같아요. 프로세스 피닉스 추가해서 오겠습니다.