Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: FCM EVENT AOP #123

Open
dongchandev opened this issue Sep 24, 2024 · 0 comments · May be fixed by #124
Open

Refactor: FCM EVENT AOP #123

dongchandev opened this issue Sep 24, 2024 · 0 comments · May be fixed by #124

Comments

@dongchandev
Copy link
Member

기존에 어떤 부분이 문제였는지 설명해주세요.

심자,외출,외박 신청에 대한 상호작용이 실패해도 fcm이 날라가게 됨

어떻게 개선할 것인지 설명해주세요.

@around -> @AfterReturning 으로 수정
쓸모없는 변수 삭제
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor #123: PushAlarmAspect에서 AOP @Around -> @AfterReturning Team-B1ND/dodamdodam-server
1 participant
@dongchandev