Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move do_not_use_time to the relevant SBF block definition. Do static members affect structures with #pragma pack(push, 1) packing? #17

Open
surajRathi opened this issue Jul 9, 2021 · 0 comments
Open

Move do_not_use_time to the relevant SBF block definition. Do static members affect structures with #pragma pack(push, 1) packing? #17

surajRathi opened this issue Jul 9, 2021 · 0 comments

Comments

@surajRathi
Copy link
Member

Low priority.

Can we move do_not_use_time from block_parsers.h to cartesian.cpp and geodetic.cpp.

Why: do_not_use_time is a feature of the block, not the block -> ros message converter.

Why is it not done yet: need to verify that static members will not affect memory order in #pragma pack(push, 1) structures.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@surajRathi