-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
benchmark time period #181
Comments
BTW, those benchmarks were done on my freebsd desktop. Would it be helpful if I used some standard EC2 hardware, like C6g.medium or c5.large? |
My concern with benchmarks is "warming up" -- you can see in those graphs that the performance in the first second is higher than later, presumably because data structures are clean and kvlds isn't being slowed down by needing to evict pages from memory. How long this warmup period takes will depend on the benchmark, so I went with a conservative value. I'm not expecting to run these benchmarks very often -- they exist mainly for comparing between versions -- so I'm not too concerned about them taking a while to run. |
And yes, for comparison purposes these need to run on standard hardware. But no rush right now. |
Sure, but the means of 50 to 60 are quite far in the first two examples:
whereas the medians of 10 to 60 are closer (although admittedly not as close as I was expecting).
|
Did you forget a |
Oops. Yeah, that gives much more similar values. Invoking a useless cat since it adds clarity:
|
Sounds good to me. BTW the low performance on |
The FreeBSD kernel has a setting which tells is where to get the time from, and the default is suboptimal, at least for x86. |
Do you have a particular intuition behind taking a particular time range (such as 50 to 60 seconds for
bulk_update
)?In the attached pngs, it looks like the number of operations per second in
bulk_update
are randomly distributed. Here's 3 tests (I cancelled the last one a little bit early).I'd be tempted to use the median, or the 25% & 75% quadrants, rather than the mean of a specific time range.
(As it happens, I spent the past 2 days working on perftests for spiped, so I have this in my mind.)
The text was updated successfully, but these errors were encountered: