Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UNDEFINED enum value should be removed #72

Open
davidboden opened this issue Nov 19, 2020 · 0 comments
Open

UNDEFINED enum value should be removed #72

davidboden opened this issue Nov 19, 2020 · 0 comments

Comments

@davidboden
Copy link

davidboden commented Nov 19, 2020 •
edited
Loading

The concept of an unknown CurrencyCode or CountryCode is much better represented as Optional.empty() or null.

The documentation would benefit from a mention that these values exist and the motivation for adding them. It will be a surprise to most users of these enumerations that the UNDEFINED value exists.
@davidboden davidboden changed the title UNKNOWN enum values should be removed UNDEFINED enum value should be removed May 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@davidboden