Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Ctrl+Click to Deselect No Longer Functions #732

Closed
3 tasks done
CyanVoxel opened this issue Jan 25, 2025 · 1 comment
Closed
3 tasks done

[Bug]: Ctrl+Click to Deselect No Longer Functions #732

CyanVoxel opened this issue Jan 25, 2025 · 1 comment
Labels
Priority: Critical An issue that requires immediate attention Type: Bug Something isn't working as intended Type: UI/UX User interface and/or user experience
Milestone
SQL Parity

Comments

@CyanVoxel
Copy link
Member

Checklist

  • I am using an up-to-date version.
  • I have read the documentation.
  • I have searched existing issues.

TagStudio Version

Alpha 9.5.0 (main branch)

Operating System & Version

macOS 15

Description

Ctrl+clicking selected thumbnails to deselect them no longer functions. This seems to come from #710 as reverting that change fixes this issue. Presumably after that change the click callback only ever fires once, leading to subsequent clicks such as ctrl+clicks to not trigger the toggle_item_selection() method.

Expected Behavior

Ctrl+clicking a selected thumbnail should individually deselect it, meanwhile there should not be a regression of #706.

Steps to Reproduce

  1. In an open TagStudio library, select an item in the thumbnail grid
  2. Ctrl+Click the same item and observe it remaining selected

Logs

No response
@CyanVoxel CyanVoxel added Priority: High An important issue requiring attention Type: Bug Something isn't working as intended Type: UI/UX User interface and/or user experience labels Jan 25, 2025
@CyanVoxel CyanVoxel added this to the SQL Parity milestone Jan 25, 2025
@CyanVoxel CyanVoxel pinned this issue Jan 26, 2025
@CyanVoxel CyanVoxel added Priority: Critical An issue that requires immediate attention and removed Priority: High An important issue requiring attention labels Jan 28, 2025
@CyanVoxel CyanVoxel moved this to 🛠 Ready for Development in TagStudio Development Jan 28, 2025
@CyanVoxel CyanVoxel mentioned this issue Jan 28, 2025
Merged
@CyanVoxel
Copy link
Member Author

Resolved in #742

@github-project-automation github-project-automation bot moved this from 🛠 Ready for Development to ✅ Done in TagStudio Development Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Priority: Critical An issue that requires immediate attention Type: Bug Something isn't working as intended Type: UI/UX User interface and/or user experience
Projects
TagStudio Development
Status: ✅ Done
Milestone
SQL Parity
Development

No branches or pull requests
1 participant
@CyanVoxel