Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dimension for Volume #18

Open
TRoboto opened this issue Sep 20, 2021 · 0 comments
Open

Add dimension for Volume #18

TRoboto opened this issue Sep 20, 2021 · 0 comments
Labels
feature request Feature request parsing Concerning the parsers module.

Comments

@TRoboto
Copy link
Owner

TRoboto commented Sep 20, 2021

What problem are you trying to solve?

Currently volume parsing isn't implemented. This implements the volume dimension.

Check the documentation here for more information on creating a custom dimension.

Examples (if relevant)

This should be used as follows:

from maha.parsers.functions import parse_dimension
sample_text = "الف وعشر لترات او مئة جالون او 44.5 متر مكعب"
result = parse_dimension(sample_text, volume=True)
assert len(result) == 3

Definition of Done

  • It must adhere to the coding style used in the defined dimensions, preferably duration/time dimension.
  • The implementation should cover most use cases.
  • The value of each result should be an instance of ValueUnit.
@TRoboto TRoboto added new feature Enhancement specifically adding a new feature feature request Feature request parsing Concerning the parsers module. and removed new feature Enhancement specifically adding a new feature labels Sep 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Feature request parsing Concerning the parsers module.
Projects
None yet
Development

No branches or pull requests

1 participant