Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Slice matching does not group classes of subnamespaces into the correct slice #208

Open
MikeOnTea opened this issue Mar 17, 2023 · 0 comments
Open

Slice matching does not group classes of subnamespaces into the correct slice #208

MikeOnTea opened this issue Mar 17, 2023 · 0 comments
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@MikeOnTea
Copy link

Given these example dependencies:

Module.One.Class1 -> Module.Two.Class1
Module.Two.Class2 -> Module.One.Class1

a slice rule of Slices().Matching("Module.(*)").Should().BeFreeOfCycles() finds the dependency cycle.
However, if you move Class2 into a sub-namespace, the cycle no longer gets detected:

Module.One.Class1 -> Module.Two.Class1
Module.Two.InnerNamespace.Class2 -> Module.One.Class1
@MikeOnTea MikeOnTea changed the title Slice matching ignores subnamespaces Slice matching does not group classes of subnamespaces into the correct slice Mar 17, 2023
@alexanderlinne alexanderlinne added the kind/bug Categorizes issue or PR as related to a bug. label Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alexanderlinne @MikeOnTea