Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Admin-UI management bugs #1588

Draft
wants to merge 22 commits into
base: develop
Choose a base branch
from
Draft

Fix Admin-UI management bugs #1588

wants to merge 22 commits into from

Conversation

SamuelWei
Copy link
Collaborator

Fixes #

Type (Highlight the corresponding type)

  • Bugfix
  • Feature
  • Documentation
  • Refactoring (e.g. Style updates, Test implementation, etc.)
  • Other (please describe):

Checklist

  • Code updated to current develop branch head
  • Passes CI checks
  • Is a part of an issue
  • Tests added for the bugfix or newly implemented feature, describe below why if not
  • Changelog is updated
  • Documentation of code and features exists

Changes

Other information

@SamuelWei SamuelWei marked this pull request as draft November 19, 2024 16:47
@codecov Codecov
Copy link

codecov bot commented Nov 19, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 8.33333% with 11 lines in your changes missing coverage. Please review.

Project coverage is 81.00%. Comparing base (c55f620) to head (aef6a1d).

Files with missing lines Patch % Lines
...es/js/components/SettingsRoomTypesDeleteButton.vue 0.00% 3 Missing ⚠️
resources/js/views/AdminRoomTypesIndex.vue 0.00% 3 Missing ⚠️
resources/js/views/AdminSettings.vue 0.00% 3 Missing ⚠️
resources/js/views/AdminServerPoolsView.vue 0.00% 1 Missing ⚠️
resources/js/views/AdminUsersIndex.vue 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@              Coverage Diff              @@
##             develop    #1588      +/-   ##
=============================================
- Coverage      81.07%   81.00%   -0.07%     
  Complexity      1351     1351              
=============================================
  Files            361      361              
  Lines           9269     9277       +8     
  Branches         860      861       +1     
=============================================
  Hits            7515     7515              
- Misses          1754     1762       +8

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cypress Cypress
Copy link

cypress bot commented Nov 19, 2024 •
edited
Loading

PILOS    Run #1610

Run Properties:  status check passed Passed #1610  •  git commit aef6a1d79a: Fix Admin-UI management bugs
Project PILOS
Branch Review fix-admin-ui-user-management
Run status status check passed Passed #1610
Run duration 04m 53s
Commit git commit aef6a1d79a: Fix Admin-UI management bugs
Committer Samuel Weirich
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 237
View all changes introduced in this branch ↗︎

@SamuelWei SamuelWei changed the title Fix Admin-UI user management bugs Fix Admin-UI management bugs Nov 20, 2024
This was linked to issues Dec 16, 2024
Search not disabled during loading on admin index pages #1675
Open
Overlay not shown after loading error on some admin view pages #1677
Open
@Sabr1n4W Sabr1n4W linked an issue Dec 16, 2024 that may be closed by this pull request
Dialog buttons not disabled correctly during actions on admin pages #1711
Open
@Sabr1n4W Sabr1n4W linked an issue Jan 9, 2025 that may be closed by this pull request
BBB logo image url input not cleared correctly (AdminSettings) #1751
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@SamuelWei @Sabr1n4W