Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor file access #1409

Open
SamuelWei opened this issue Sep 22, 2024 · 0 comments
Open

Refactor file access #1409

SamuelWei opened this issue Sep 22, 2024 · 0 comments
Labels
enhancement New feature or request refactor
Milestone

Comments

@SamuelWei
Copy link
Collaborator

Currently, room files are listed and when clicked, an async function is triggered to generate a short live link to download the file.
This is a problem as some browsers block the opening of a new window that is not directly caused by a user action.

Currently, the room token and room access code are sent in the header of all API requests to authenticate a user against the room.
A file access link is not an API request, so setting the header is not possible.

A new approach could be to generate an encrypted auth token when a user authenticates against the room via the api and associate this with the user's session. This token could be sent via a get request parameter during file access to check if the access code or token is still valid, while still protecting the token/code from being exposed in server logs, etc.

@SamuelWei SamuelWei added enhancement New feature or request refactor labels Sep 22, 2024
@SamuelWei SamuelWei modified the milestones: v4.1, v4.2 Sep 23, 2024
@SamuelWei SamuelWei modified the milestones: v4.2, v4.3 Nov 25, 2024
@SamuelWei SamuelWei modified the milestones: v4.3, v4.4 Dec 19, 2024
@SamuelWei SamuelWei modified the milestones: v4.3, v4.4 Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request refactor
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

1 participant