Tests failing following recent changes to VexFlow

[davethehat]

At least in part to vexflow-overides.js not being current with the recent refactorings. Should really try to ditch this and work with 'pure' vexflow (which may mean folding changes back into vexflow itself)

[aerhard]

I totally agree -- the file has grown too big, there should already be
obsolete things we can remove easily thanks to VexFlow's fast
development in the last couple of weeks. One or two weeks ago I sent a
PR for mei2vf to work with VexFlow, but I haven't checked compatibility
since then -- it might be broken again, there have been a couple of
changes in VexFlow since then. @zolaemil or @raffazizzi - could you have
a look at the adjustments in
#61 ?

Am 21.08.2014 14:41, schrieb David Harvey:

At least in part to vexflow-overides.js not being current with the
recent refactorings. Should really try to ditch this and work with
'pure' vexflow (which may mean folding changes back into vexflow itself)

—
Reply to this email directly or view it on GitHub
#64.

[aerhard]

ah, wait... just checked it: my changes in the PR won't make mei2vf work with the most recent version of VexFlow, there are more adjustments necessary

[davethehat]

I've removed a few things from the overrides file - all seems to pass. This may/may not conflict with your request, Alexander

D

[aerhard]

Ah, good, thanks for the message! I'll have a look and adjust things in
my PR if necessary.

Am 26.08.2014 13:05, schrieb David Harvey:

I've removed a few things from the overrides file - all seems to pass.
This may/may not conflict with your request, Alexander

D

—
Reply to this email directly or view it on GitHub
#64 (comment).

[aerhard]

I only had two conflicts in the overrides' file, both deletions by you, modifications by me; i sent a feature request to VexFlow, so the first of the passages (KeySignature class) should be totally redundant soon (currently, it only has got an effect when there are simultaneous key signatures following clefs of different width: these key signatures get aligned -- I think this isn't covered in tests.html). I can't tell about the second passage (Stave class) -- @zolaemil?