Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[S1/Custom] CustomApply Post haveDesign 값 전달 방식 수정 / haveDesign 플래그 값 변동 #615

Merged
merged 5 commits into from
Feb 24, 2024
Merged

[S1/Custom] CustomApply Post haveDesign 값 전달 방식 수정 / haveDesign 플래그 값 변동 #615

merged 5 commits into from
Feb 24, 2024

Conversation

Yeonseo-Jo
Copy link
Member

@Yeonseo-Jo Yeonseo-Jo commented Feb 21, 2024 •
edited
Loading

🔥 Related Issues

resolved #614

💜 작업 내용

  • CustomApply Post haveDesign 값 전달 방식 수정

  • 구조 바뀌면서 안쓰는 hook 삭제

  • 서버 요청에 따라 haveDesign 플래그 의미하는 값 수정

✅ PR Point

1. 관련 이슈

image

2. 원인

  • 제작 방식 선택 이전에 통신이 이루어 지고 있었음
    • hook으로 만들었던 usePostCustomApply 함수가 selectCustomFooter가 렌더링 될 때 실행되어, 유저가 두 제작 방식 선택 버튼 중 하나를 클릭하기 이전에 통신이 되었던것
    • 그래서 항상 값이 false로 들어감 (이걸 왜 내내 모르다가 지금 알았는지 놀랄 노자)
image

3. 해결

  • isActiveNext === 즉, 유저가 두 제작 방식 중 하나를 선택 했을 때, 서버에게 /custom/apply endpoint의 post 요청을 보내도록 로직 수정

추가) haveDesign 플래그 값 변동

image

<결론>

  • 스케치 없는거(연서 담당) : haveDesign = true / url : /haveDesign
  • 스케치 있는거(지민 담당) : haveDesign = false / url : /noDesign
    입니다!

😡 Trouble Shooting

  • x

☀️ 스크린샷 / GIF / 화면 녹화

@Yeonseo-Jo Yeonseo-Jo added the 🔨 Refactor 리팩토링 label Feb 21, 2024
@Yeonseo-Jo Yeonseo-Jo self-assigned this Feb 21, 2024
@netlify Netlify
Copy link

netlify bot commented Feb 21, 2024 •
edited
Loading

✅ Deploy Preview for tattour ready!

Name Link
🔨 Latest commit ac0fcd0
🔍 Latest deploy log https://app.netlify.com/sites/tattour/deploys/65da1c87be6e3c0008b41b76
😎 Deploy Preview https://deploy-preview-615--tattour.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Yeonseo-Jo Yeonseo-Jo linked an issue Feb 21, 2024 that may be closed by this pull request
[S1] CustomApply Post haveDesign 값 전달 방식 수정 #614
Open
1 task
@Yeonseo-Jo Yeonseo-Jo changed the title [S1/Custom] CustomApply Post haveDesign 값 전달 방식 수정 [S1/Custom] CustomApply Post haveDesign 값 전달 방식 수정 / haveDesign 플래그 값 상호 교환 Feb 22, 2024
@Yeonseo-Jo Yeonseo-Jo changed the title [S1/Custom] CustomApply Post haveDesign 값 전달 방식 수정 / haveDesign 플래그 값 상호 교환 [S1/Custom] CustomApply Post haveDesign 값 전달 방식 수정 / haveDesign 플래그 값 변동 Feb 22, 2024
@lydiacho
Copy link
Member

와 치명적인 QA 사항인데 연서 말대로 지금 발견된게 정말 놀랄노자네요 지금이라도 발견해서 늦은 시간에 빠르게 처리해주셔서 감사합니다!!! 💯

Arooming
Arooming approved these changes Feb 24, 2024
View reviewed changes
Copy link
Member

@Arooming Arooming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

헉스 이걸 진짜 지금 알게된게 신기하네요?! 왜 모두 이상한걸 몰랐는지..!!
암튼 그래두 지금이라도 알아서 다행이네용 ~~ 수고했쑵니당 !

@lydiacho lydiacho self-requested a review February 24, 2024 11:16
@Yeonseo-Jo Yeonseo-Jo merged commit 492f969 into develop Feb 24, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Arooming Arooming Arooming approved these changes

@lydiacho lydiacho Awaiting requested review from lydiacho

Assignees

@Yeonseo-Jo Yeonseo-Jo

Labels
🔨 Refactor 리팩토링
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[S1] CustomApply Post haveDesign 값 전달 방식 수정
3 participants
@Yeonseo-Jo @lydiacho @Arooming