Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Orientation values need to be updated #431

Open
jakebeal opened this issue Apr 8, 2023 · 1 comment
Open

Orientation values need to be updated #431

jakebeal opened this issue Apr 8, 2023 · 1 comment
Labels
enhancement New feature or request
Milestone

Comments

@jakebeal
Copy link
Contributor

jakebeal commented Apr 8, 2023

The SBOL_INLINE and SBOL_REVERSE_COMPLEMENT constants were changed between specification 3.0.0 and 3.0.1, to use sequence ontology terms. The old terms are still accepted as dispreferred alternates. To track this change in the specification, this library should:

  • Switch the constants to the new SO values
  • Make "alternate" constants for the old values
  • Make sure validation rules are updated to accept both values
  • Automatically upgrade features supplied with the old value to use the new value
  • Add tests for both values
@jakebeal jakebeal added enhancement New feature or request good first issue Good for newcomers and removed good first issue Good for newcomers labels Apr 8, 2023
@jakebeal
Copy link
Contributor Author

jakebeal commented Apr 8, 2023

Actually, I see that the other terms are already in there as well, as SO_FORWARD and SO_REVERSE, so maybe this is more a matter of deprecation or documentation to try to point people to using the preferred term in some way?

@tcmitchell tcmitchell added this to the 1.2 milestone Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants