Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

columnar to do the sf_to_df after processing (colours, arguments) #50

Closed
1 task
dcooley opened this issue Mar 22, 2020 · 1 comment
Closed
1 task

columnar to do the sf_to_df after processing (colours, arguments) #50

dcooley opened this issue Mar 22, 2020 · 1 comment

Comments

@dcooley
Copy link
Collaborator

dcooley commented Mar 22, 2020 •
edited
Loading

If the user supplied an argument like

stroke_width = 10

to a function call, this 10 needs to apply to every row of data.

When using the columnar format the sf object is unlisted and processed. This should be the other way around, so the colours (etc.) are calculated and assigned on smaller data, then expanded. Which will also mean this 10 is applied to every row.

TODO

  • Move the sf_to_df() into spatialwidget::create_columnar()
@dcooley
Copy link
Collaborator Author

dcooley commented Nov 2, 2020

sorting this out in #52

@dcooley dcooley closed this as completed Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dcooley