Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sylius admin route prefix not customizable #274

Open
lruozzi9 opened this issue May 7, 2021 · 0 comments
Open

Sylius admin route prefix not customizable #274

lruozzi9 opened this issue May 7, 2021 · 0 comments

Comments

@lruozzi9
Copy link

lruozzi9 commented May 7, 2021

By the v1.8 of Sylius, the SyliusAdminBundle routes prefix can be modified thanks to the use of an environment variable (Sylius/SyliusAdminBundle@eb93fc1).

However, this is possible as long as you don't use plugins with admin routes. Many of these, in fact, define, in the routing configuration file, the admin prefix statically as part of the path (like this). Others don't use the prefix (like this) and let the user define the prefix as here. This second solution will be profitable because you could use the %sylius_admin.path_name% as a prefix.
What do you think about these? IMHO we should define a standard compatible with Sylius < 1.8, and for example, updates the routes.yaml file by using the correct prefix parameter or admin if is not defined.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant