Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Less strict about Sylius version #130

Closed
stefandoorn opened this issue Oct 4, 2018 · 2 comments
Closed

Less strict about Sylius version #130

stefandoorn opened this issue Oct 4, 2018 · 2 comments
Labels
RFC

Comments

@stefandoorn
Copy link
Contributor

Current installation requires "sylius/sylius": "~1.4.0@dev",. Can't that just be that latest supported Sylius version? In that case plugin developers take a wider range of Sylius versions in mind (also should maybe be tested against in Travis), and not only using latest versions. Makes plugins available to a bigger group of developers.
@stefandoorn
Copy link
Contributor Author

E.g. if you change a plugin that started at 1.2.x to ^1.1, all fails now due to changes in 1.3.. Probably the test setup needs to be 1.3 compatible, while the src folder can be 1.1 compatible then.

@pamil pamil added the RFC label Oct 11, 2018
@stefandoorn stefandoorn mentioned this issue Dec 4, 2018
Closed
@pamil
Copy link
Contributor

pamil commented Jun 3, 2020

There are some BC breaks regarding the CI setup mostly, let's keep the discussion in #104, since allowing testing multiple versions of Sylius at the same time will make it possible to loosen this constraint.

@pamil pamil closed this as completed Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
RFC
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pamil @stefandoorn