We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Right now, most of the Client class method accept commitment parameter, however it isn't actually being used when the request is being sent.
Client
This part is where the commitment needs to be added: https://github.com/SuperteamDAO/solathon/blob/master/solathon/core/http.py
Solana JSON RPC commitment reference: https://docs.solana.com/api/http#example
The logic is simple. If the user enters parameters array, with an object, having "commitment" key, then we have to add it to our request. The commitment is validated using this helper function: https://github.com/SuperteamDAO/solathon/blob/master/solathon/utils.py#L27
Also, some important RPC methods like send_transaction don't have commitment parameter accepted yet either, so that needs to be added too.
send_transaction
The text was updated successfully, but these errors were encountered:
Successfully merging a pull request may close this issue.
Right now, most of the
Client
class method accept commitment parameter, however it isn't actually being used when the request is being sent.This part is where the commitment needs to be added: https://github.com/SuperteamDAO/solathon/blob/master/solathon/core/http.py
Solana JSON RPC commitment reference: https://docs.solana.com/api/http#example
The logic is simple. If the user enters parameters array, with an object, having "commitment" key, then we have to add it to our request.
The commitment is validated using this helper function: https://github.com/SuperteamDAO/solathon/blob/master/solathon/utils.py#L27
Also, some important RPC methods like
send_transaction
don't have commitment parameter accepted yet either, so that needs to be added too.The text was updated successfully, but these errors were encountered: