Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filter out "none" as a gene alias #119

Open
andrewsu opened this issue Aug 2, 2019 · 2 comments
Open

filter out "none" as a gene alias #119

andrewsu opened this issue Aug 2, 2019 · 2 comments
Assignees

Comments

@andrewsu
Copy link
Member

andrewsu commented Aug 2, 2019

Per this bug report, the Gene bot added "None" as a gene alias. Our bot should filter aliases like this out. More generally, I'm sure there are other such nonsensical aliases, so we should plan to have a list of blacklisted aliases to easily incorporate similar examples we encounter in the future.

@andrawaag
Copy link

andrawaag commented Aug 22, 2019

Reopen it for now, I made a fix by introducing not_worth_adding as a list not to add as alias. It currently contains:

not_worth_adding = {
"none",
"None",
"gene",
"Gene"
}

The list can be extended at https://github.com/SuLab/scheduled-bots/blob/master/scheduled_bots/geneprotein/__init__.py#L31

The issue got closed automatically when this was referenced in the commit of the fix. Reopen it for now until subsequent Jenkins runs confirm its working.

@andrawaag andrawaag reopened this Aug 22, 2019
@andrewsu
Copy link
Member Author

related issue (and fix) on protein aliases: SuLab/scheduled-bots#8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants