Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net::ERR_CERT_AUTHORITY_INVALID // ignoreHTTPSErrors #222

Open
sbounmy opened this issue Jan 29, 2024 · 2 comments
Open

net::ERR_CERT_AUTHORITY_INVALID // ignoreHTTPSErrors #222

sbounmy opened this issue Jan 29, 2024 · 2 comments

Comments

@sbounmy
Copy link
Contributor

sbounmy commented Jan 29, 2024

Encountering Grover::JavaScript::Error net::ERR_CERT_AUTHORITY_INVALID

because I now have setup ssl on localhost.

Stumbled on puppeteer/puppeteer#1137 (comment) telling to setup chromium with ignoreHTTPSErrors

How would we do it with Grover?

@sbounmy
Copy link
Contributor Author

sbounmy commented Feb 1, 2024

I believe it is here where we could pass additional params such as:

await puppeteer.connect({browserWSEndpoint:"ws://chromium:9222/devtools/browser/xxx", ignoreHTTPSErrors: true})

@abrom
Copy link
Contributor

abrom commented Feb 3, 2024

Sure.. it's possible. Likely provided through a variable such as browser_ws_ignore_https_errors or similar..

In the processor.cjs it'd probably look like:

    const browserWsEndpoint = options.browserWsEndpoint; delete options.browserWsEndpoint;
    const browserWsIgnoreHttpsErrors = options.browserWsIgnoreHttpsErrors; delete options.browserWsIgnoreHttpsErrors;
    if (typeof browserWsEndpoint === "string") {
      const connectParams = {
        browserWSEndpoint: browserWsEndpoint,
      };

      if (typeof browserWsIgnoreHttpsErrors !== 'undefined') {
        connectParams.ignoreHTTPSErrors = browserWsIgnoreHttpsErrors;
      }

      browser = await puppeteer.connect(connectParams);

      .....

I'd happily accept a PR 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants