Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve categorization of ticker #525

Open
StephanAkkerman opened this issue Apr 4, 2024 · 2 comments
Open

Improve categorization of ticker #525

StephanAkkerman opened this issue Apr 4, 2024 · 2 comments
Labels
Difficulty: Medium 😐 This issue can be solved, but a decent amount of lines need to be changed Important ❗ Issue is important! Overhaul 🌈 Overhaul a part of the code Priority: High 🥇 Assign this label if this issue is VERY important or often used

Comments

@StephanAkkerman
Copy link
Owner

StephanAkkerman commented Apr 4, 2024 •
edited
Loading

The current approach seems a bit too API-heavy. Maybe we can change it so that we use a static list of NASDAQ tickers and some popular crypto tickers to categorize it.

Ideas:

  • Save more data, for instance anything for classifying tickers we get back from yahoo finance, coingecko, TV, etc.
  • The goal is to have a clear list of which tickers / names / ids are crypto and which are stocks or forex.
  • Use caching (see Cache ticker data to reduce API load #505 )
  • Look into rotating proxies for coingecko (or another API)
  • Remove forex category and merge them with stocks (there are not much tweets about forex anyways)
  • Unknown tickers should always be crypto
@StephanAkkerman StephanAkkerman added Priority: Medium 🥈 Assign this label if this issue is used around once a day Overhaul 🌈 Overhaul a part of the code Difficulty: Medium 😐 This issue can be solved, but a decent amount of lines need to be changed labels Apr 4, 2024
@StephanAkkerman
Copy link
Owner Author

Remove charts and text channels for forex and merge them back to stocks. Nobody tweets about forex ever and it only takes time to process forex tickers seperately

@StephanAkkerman
Copy link
Owner Author

StephanAkkerman commented May 26, 2024 •
edited
Loading

Always use crypto category if the ticker is unknown + scan for common tickers in tweet for instance if the tweet contains BTC / bitcoin, ETH / ethereum, altcoins etc.

@StephanAkkerman StephanAkkerman added Important ❗ Issue is important! Priority: High 🥇 Assign this label if this issue is VERY important or often used and removed Priority: Medium 🥈 Assign this label if this issue is used around once a day labels Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Difficulty: Medium 😐 This issue can be solved, but a decent amount of lines need to be changed Important ❗ Issue is important! Overhaul 🌈 Overhaul a part of the code Priority: High 🥇 Assign this label if this issue is VERY important or often used
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@StephanAkkerman