Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional compilation #3903

Open
alex-w opened this issue Sep 21, 2024 · 3 comments
Open

Optional compilation #3903

alex-w opened this issue Sep 21, 2024 · 3 comments
Labels
importance: low Small problem, rarely visible, no crash infrastructure Infrastructure related issues subsystem: gui The issue is related to GUI subsystem of planetarium...

Comments

@alex-w
Copy link
Member

alex-w commented Sep 21, 2024

Expected Behaviour

Optional compilation (for example without GUI) is working

Actual Behaviour

Compilation after configuration with option -DSTELLARIUM_GUI_MODE=None is not possible. I fear compilation without scripting can be broken too.

P.S. After resolving problems we can add checks some optional compilations in CI

@alex-w alex-w added the infrastructure Infrastructure related issues label Sep 21, 2024
@alex-w alex-w added this to the 24.4 milestone Sep 21, 2024
@gzotti
Copy link
Member

gzotti commented Sep 21, 2024

Certainly possible. I have not tried None in the past 8 years or so. While I don't see the actual necessity for None, it is a pre-requisite for starting any alternative GUIs of course. Likewise with scripting, the focus was on running with either QtScript (Qt5) or QML (Qt6), not disabling it completely.

@alex-w alex-w self-assigned this Sep 21, 2024
@alex-w
Copy link
Member Author

alex-w commented Sep 21, 2024

OK, at least for all documented modular features optional compilation is working - see linked branch.

@alex-w alex-w added the importance: low Small problem, rarely visible, no crash label Sep 30, 2024
@alex-w alex-w removed this from the 24.4 milestone Sep 30, 2024
@alex-w alex-w removed their assignment Oct 5, 2024
@alex-w
Copy link
Member Author

alex-w commented Oct 5, 2024

Well, at the moment only -DSTELLARIUM_GUI_MODE=None has broken and without alternative GUI it’s not critical option. Of course, in the future (when new optional GUI will be added) we should refactored calling GUI features in the core (hello to screenshots for example).

@alex-w alex-w added the subsystem: gui The issue is related to GUI subsystem of planetarium... label Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
importance: low Small problem, rarely visible, no crash infrastructure Infrastructure related issues subsystem: gui The issue is related to GUI subsystem of planetarium...
Development

No branches or pull requests

2 participants