Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding references in constellation names file results in parse error #2055

Closed
kajaji opened this issue Nov 21, 2021 · 4 comments
Closed

Adding references in constellation names file results in parse error #2055

kajaji opened this issue Nov 21, 2021 · 4 comments
Assignees
Labels
bug Something likely wrong in the code importance: low Small problem, rarely visible, no crash purpose: cultural astronomy Issues, pull requests and proposals with cultural astronomy purposes state: confirmed A developer can reproduce the issue
Milestone

Comments

@kajaji
Copy link
Contributor

kajaji commented Nov 21, 2021

In building records in constellation_names.eng.fab and adding references like:
0100 "الفرقدان" _("The two oryx calves") 1,2,3,4
I get this message in the log.txt file:
ERROR - cannot parse record at line 1 in constellation names file "C:\Users\kaaaj\AppData\Roaming\Stellarium\skycultures\arabic\constellation_names.eng.fab" : "0100 "الفرقدان" _("The two oryx calves") 1,2,3,4\n"
while I beleive I follow the specs in the user guide.

Adding similar references in the star_names.fab passes without issues.

Is the issue here?

QRegExp recRx("^\\s*(\\.?\\w+)\\s+\"(.*)\"\\s+_[(]\"(.*)\"[)]\\s*(\\w*)\\n");

@gzotti gzotti added enhancement Improve existing functionality and removed enhancement Improve existing functionality labels Nov 21, 2021
@gzotti
Copy link
Member

gzotti commented Nov 21, 2021

Indeed. It seems commas are currently not allowed in the regular expression. These constellation comments are not yet in use, but are important assets in the future. Please hold back a few weeks until this is available in a beta. It should certainly be possible in 0.21.3.

@gzotti gzotti added bug Something likely wrong in the code state: confirmed A developer can reproduce the issue importance: low Small problem, rarely visible, no crash labels Nov 21, 2021
@gzotti gzotti added this to the 0.21.3 milestone Nov 21, 2021
@github-actions
Copy link

Hello @kajaji! OK, developers can reproduce the issue. Thanks for the report!

@Stellarium Stellarium deleted a comment from github-actions bot Nov 21, 2021
@gzotti gzotti closed this as completed in 32e76d1 Nov 22, 2021
@gzotti gzotti self-assigned this Nov 22, 2021
@github-actions
Copy link

Hello @kajaji! Please check the fresh version (development snapshot) of Stellarium:
https://github.com/Stellarium/stellarium-data/releases/tag/weekly-snapshot

@github-actions
Copy link

Hello @kajaji! Please check the latest stable version of Stellarium:
https://github.com/Stellarium/stellarium/releases/latest

@alex-w alex-w added the purpose: cultural astronomy Issues, pull requests and proposals with cultural astronomy purposes label Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something likely wrong in the code importance: low Small problem, rarely visible, no crash purpose: cultural astronomy Issues, pull requests and proposals with cultural astronomy purposes state: confirmed A developer can reproduce the issue
Development

No branches or pull requests

3 participants